ci: add doctor focus and project config defaults#10
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9b71cf978
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fi | ||
|
|
||
| if command -v go >/dev/null 2>&1; then | ||
| if go run ./cmd/runner_health >/dev/null 2>&1; then |
There was a problem hiding this comment.
ci-self doctor invokes go run ./cmd/runner_health relative to the caller’s current directory, so running the globally installed CLI from a target project (the documented workflow) makes this check fail because ./cmd/runner_health is not present there; the same relative-path pattern is used for runner_setup --fix. This causes false failures (and broken fixes) even on healthy runner hosts unless the user happens to run doctor from this repository root.
Useful? React with 👍 / 👎.
| [[ -n "$CONFIG_PROJECT_DIR" && "$project_dir" == "$PWD" ]] && project_dir="$CONFIG_PROJECT_DIR" | ||
| project_dir="$(expand_local_path "$project_dir")" | ||
| [[ -z "$base" && -n "$CONFIG_PR_BASE" ]] && base="$CONFIG_PR_BASE" | ||
| [[ -n "$CONFIG_PR_BASE" && "$base" == "main" ]] && base="$CONFIG_PR_BASE" |
There was a problem hiding this comment.
This line unconditionally replaces base=main with CI_SELF_PR_BASE, so ci-self focus --base main still targets the configured base branch (for example, develop) instead of the user’s explicit CLI argument. Because the config template states CLI options should override config, this creates unexpected PR targets whenever the configured base differs from main.
Useful? React with 👍 / 👎.
1 participant
No description provided.