Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e0cf02f04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local remote_script | ||
|
|
||
| remote_args_q="$(quote_words "${remote_args[@]}")" | ||
| printf -v remote_script 'set -euo pipefail; cd %q; %q %s' "$project_dir" "$remote_cli" "$remote_args_q" |
There was a problem hiding this comment.
~ expansion when building SSH command
When --project-dir is omitted, the remote commands fall back to ~/dev/<repo>, but this line builds the SSH payload with cd %q, which turns that into cd \~/dev/<repo>. Because the tilde is escaped, the remote shell does not expand $HOME, so remote-register, remote-run-focus, and remote-up fail unless callers pass an explicit absolute path. This breaks the documented default-path behavior.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 503b253151
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local remote_script | ||
|
|
||
| remote_args_q="$(quote_words "${remote_args[@]}")" | ||
| printf -v remote_script 'set -euo pipefail; cd %q; %q %s' "$project_dir" "$remote_cli" "$remote_args_q" |
There was a problem hiding this comment.
~ expansion in remote CLI path
In run_remote_ci_self, remote_cli is interpolated with %q, which turns a user-supplied --remote-cli ~/.local/bin/ci-self into \~/.local/bin/ci-self on the remote side, so Bash treats it as a literal filename instead of expanding $HOME. This breaks remote-register, remote-run-focus, and remote-up for hosts where ci-self is installed but not on PATH (the common fallback is passing ~/.local/bin/ci-self).
Useful? React with 👍 / 👎.
1 participant
No description provided.