Add named import syntax for ESM imports#16
Open
marcoroth wants to merge 1 commit intomtgrosser:masterfrom
Open
Add named import syntax for ESM imports#16marcoroth wants to merge 1 commit intomtgrosser:masterfrom
marcoroth wants to merge 1 commit intomtgrosser:masterfrom
Conversation
Author
|
I kept this pull request simple as this is mostly a convenience thing, but I have also been thinking about the following for multiple imports and import aliasing: import [:v4, :v1], from: 'uuid'
# => import { v4, v1 } from 'uuid'
import { v4: :generateUuid }, from: 'uuid'
# => import { v4 as generateUuid } from 'uuid'Happy to open a separate pull request for this, or add it to this one if you like this functionality as well! 🙌🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In modern JavaScript it's quite common to use the named import syntax over importing the default export from a package or importing the whole package using the star alias imports.
This pull request adds support for the named import syntax for ESM modules.
The following JavaScript import:
Can now be represented as the following in
Nodo::Core:I chose this syntax with the
fromkwarg, but if you prefer a different syntax for this please let me know 🙌🏼