Updated to use Jenkins API, handles deletion using thresholds.#4
Open
franostanisicserato wants to merge 13 commits intomthak:masterfrom
Open
Updated to use Jenkins API, handles deletion using thresholds.#4franostanisicserato wants to merge 13 commits intomthak:masterfrom
franostanisicserato wants to merge 13 commits intomthak:masterfrom
Conversation
…g jenkins API and thersholds.
…g jenkins API and thresholds.
Author
|
Just making this request here in addition to the Jenkins branch, as a suggestion of improvements. I am not sure if this is still worked on. |
added 7 commits
October 26, 2017 14:41
This was happening when a slave was connecting and did not have any disk information, then the plugin was doing a system.exit()...
Removed unused and empty parameters.
Followed bug/warning from the build to remove the warnings.
Jelly now needs this line for security reasons.
As it's the output build.
It was failing with weird errors otherwise, also it was quite outdated.
We don't want to have the same version as the original plugin to avoid updating our one with the official one (as shown in Jenkins plugin manager) so we make sure it's higher. We will eventually use our own version/id to diverge from the original one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated other pull requests, cleaned up some of the code and added a new method for deletion whereby the user specifies an upper bound to trigger the check (as prior), but instead of how it was prior (deleting all workspaces) the plugin now deletes workspaces sequentially, starting with the oldest, until a lower threshold is hit (also specified by the user). The user can also set this to 0 to delete all workspaces as the original functionality did.