Skip to content

Enable export stop_times.stop_sequence & "last trip stop" FF#26

Draft
mmathieum wants to merge 1 commit intomasterfrom
mm/turn_on_ff_stop_seq_last_trip_stop
Draft

Enable export stop_times.stop_sequence & "last trip stop" FF#26
mmathieum wants to merge 1 commit intomasterfrom
mm/turn_on_ff_stop_seq_last_trip_stop

Conversation

@mmathieum mmathieum self-assigned this Mar 9, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request activates two specific feature flags, F_EXPORT_STOP_SEQUENCE and F_EXPORT_DIRECTION_STOP_LAST, within the application's configuration. This change is intended to enable new functionalities related to how stop sequences are exported and how the last stop in a direction is handled, which will likely influence data processing and routing capabilities.

Highlights

  • Feature Flag Activation: The F_EXPORT_STOP_SEQUENCE feature flag has been enabled, changing its value from false to true.
  • Feature Flag Activation: The F_EXPORT_DIRECTION_STOP_LAST feature flag has been enabled, changing its value from false to true.
Changelog
  • src/main/java/org/mtransit/commons/FeatureFlags.kt
    • Enabled the F_EXPORT_STOP_SEQUENCE feature flag.
    • Enabled the F_EXPORT_DIRECTION_STOP_LAST feature flag.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mmathieum mmathieum added the data_change Triggers data changes label Mar 9, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables two feature flags, F_EXPORT_STOP_SEQUENCE and F_EXPORT_DIRECTION_STOP_LAST, by changing their values to true and removing the // WIP comments. The changes are straightforward. I've suggested a minor cleanup to remove the now-commented-out lines for these flags to improve code readability.

@mmathieum mmathieum changed the title Enable export stop sequence and direction last stop FF Enable export stop_times.stop sequence & direction last trip stop FF Mar 9, 2026
@mmathieum mmathieum changed the title Enable export stop_times.stop sequence & direction last trip stop FF Enable export stop_times.stop_sequence & last trip stop FF Mar 9, 2026
@mmathieum mmathieum changed the title Enable export stop_times.stop_sequence & last trip stop FF Enable export stop_times.stop_sequence & "last trip stop" FF Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data_change Triggers data changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant