Add license info to composer.json#26
Open
reiz wants to merge 1 commit into
Open
Conversation
mtudor
reviewed
Apr 23, 2018
| "name": "mtudor/zfc-user-impersonate", | ||
| "description": "Facilitate impersonation of other users in ZfcUser.", | ||
| "type": "library", | ||
| "license": "LGPL-2.1", |
Owner
There was a problem hiding this comment.
Hey @reiz - thanks for this; apologies for the record-breaking response time! Two quick questions and then we can get this merged:
-
It looks like the value of this should be "LGPL-2.1-or-later" rather than just "LGPL-2.1"? https://spdx.org/licenses/
-
Out of interest. what prompted you to need the license in composer rather than the LICENSE file; does it have a real world impact or are you just tidying up?
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.