Skip to content

[breaking change][textarea] Move padding from wrapper to actual element #48659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silviuaavram wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −69
Open

[breaking change][textarea] Move padding from wrapper to actual element #48659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
881593a
[textarea] Move padding from wrapper to actual element
silviuaavram Jun 11, 2026
eef2b21
fix visual regressions
silviuaavram Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions packages/mui-material/src/FilledInput/FilledInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,34 +166,6 @@ const FilledInputRoot = styled(InputBaseRoot, {
paddingRight: 12,
},
},
{
props: ({ ownerState }) => ownerState.multiline,
style: {
padding: '25px 12px 8px',
},
},
{
props: ({ ownerState, size }) => ownerState.multiline && size === 'small',
style: {
paddingTop: 21,
paddingBottom: 4,
},
},
{
props: ({ ownerState }) => ownerState.multiline && ownerState.hiddenLabel,
style: {
paddingTop: 16,
paddingBottom: 17,
},
},
{
props: ({ ownerState }) =>
ownerState.multiline && ownerState.hiddenLabel && ownerState.size === 'small',
style: {
paddingTop: 8,
paddingBottom: 9,
},
},
],
};
}),
Expand Down Expand Up @@ -260,15 +232,6 @@ const FilledInputInput = styled(InputBaseInput, {
paddingBottom: 9,
},
},
{
props: ({ ownerState }) => ownerState.multiline,
style: {
paddingTop: 0,
paddingBottom: 0,
paddingLeft: 0,
paddingRight: 0,
},
},
],
})),
);
Expand Down
14 changes: 0 additions & 14 deletions packages/mui-material/src/InputBase/InputBase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,18 +110,6 @@ export const InputBaseRoot = styled('div', {
cursor: 'default',
},
variants: [
{
props: ({ ownerState }) => ownerState.multiline,
style: {
padding: '4px 0 5px',
},
},
{
props: ({ ownerState, size }) => ownerState.multiline && size === 'small',
style: {
paddingTop: 1,
},
},
{
props: ({ ownerState }) => ownerState.fullWidth,
style: {
Expand Down Expand Up @@ -230,8 +218,6 @@ export const InputBaseInput = styled('input', {
style: {
height: 'auto',
resize: 'none',
padding: 0,
paddingTop: 0,
},
},
{
Expand Down
18 changes: 0 additions & 18 deletions packages/mui-material/src/OutlinedInput/OutlinedInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,6 @@ const OutlinedInputRoot = styled(InputBaseRoot, {
paddingRight: 14,
},
},
{
props: ({ ownerState }) => ownerState.multiline,
style: {
padding: '16.5px 14px',
},
},
{
props: ({ ownerState, size }) => ownerState.multiline && size === 'small',
style: {
padding: '8.5px 14px',
},
},
],
};
}),
Expand Down Expand Up @@ -158,12 +146,6 @@ const OutlinedInputInput = styled(InputBaseInput, {
padding: '8.5px 14px',
},
},
{
props: ({ ownerState }) => ownerState.multiline,
style: {
padding: 0,
},
},
{
props: ({ ownerState }) => ownerState.startAdornment,
style: {
Expand Down
7 changes: 7 additions & 0 deletions test/regressions/fixtures/Textarea/Textarea.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ function Textarea() {
fontSize: 13,
boxSizing: 'border-box',
border: '10px solid black',
padding: 0,
},
'&.MuiInput-root': {
padding: '4px 0 5px',
},
}}
multiline
Expand All @@ -29,6 +33,9 @@ function Textarea() {
sx={{
width: 200,
'& .MuiInput-input': { fontSize: 13, boxSizing: 'content-box', padding: '10px' },
'&.MuiInput-root': {
padding: '4px 0 5px',
},
}}
multiline
value={value}
Expand Down
Loading