[docs] Clarify container prop inheritance for Shadow DOM#48670
Open
Juan-C-Ceballos wants to merge 4 commits into
Open
[docs] Clarify container prop inheritance for Shadow DOM#48670Juan-C-Ceballos wants to merge 4 commits into
Juan-C-Ceballos wants to merge 4 commits into
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
mj12albert
reviewed
Jun 15, 2026
mj12albert
left a comment
mj12albert
left a comment
Member
There was a problem hiding this comment.
IMO the callout is a bit excessive and overall this could be explained within 1-2 sentences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the Shadow DOM customization page to explain why the
containerdefault only needs to be set on
Modal,Popover, andPopper.The previous wording ("components like Menu, Dialog, Popover, and others")
left two things unclear, both raised in the linked issue:
containerset.Dialog,Menu) inherit the defaultfrom the base component they render internally, or need it set separately.
This adds a short paragraph plus an info callout explaining that
Dialog,Drawer,Menu,Tooltip, andAutocompleterender one of the three basecomponents internally, and each base component reads its own default props
(
MuiModal/MuiPopover/MuiPopper) at render time. So the existingexample is already complete and there's no need to set
MuiDialog,MuiMenu,etc.
Docs-only change.
Closes #48292