Skip to content

[codemod] Bump engines.node to >=20.19 to align with yargs package#18979

Merged
LukasTy merged 2 commits into
mui:masterfrom
LukasTy:fix-codemod-engines-node
Sep 22, 2025
Merged

[codemod] Bump engines.node to >=20.19 to align with yargs package#18979
LukasTy merged 2 commits into
mui:masterfrom
LukasTy:fix-codemod-engines-node

Conversation

@LukasTy

@LukasTy LukasTy commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Based on mui/material-ui#46578 (review).

Changelog

@mui/x-codemod minimum supported Node version is 20.19.
This was only the case due to using the v18 yargs package; this only explicitly aligns with it.

@LukasTy LukasTy requested a review from a team July 30, 2025 08:04
@LukasTy LukasTy self-assigned this Jul 30, 2025
@LukasTy LukasTy added breaking change Introduces changes that are not backward compatible. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. package: codemod Specific to codemod. labels Jul 30, 2025
@mui-bot

mui-bot commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Deploy preview: https://deploy-preview-18979--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 🔺+4B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 🔺+4B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 🔺+1B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 🔺+5B(+0.01%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 🔺+2B(+0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against 28bd411

Janpot
Janpot reviewed Jul 30, 2025
View reviewed changes
Comment thread packages/x-codemod/package.json
},
"engines": {
"node": ">=14.0.0"
"node": ">=20.19"

@Janpot Janpot Jul 30, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To determine first if it's a breaking change. If the yargs update was from before v8, we could probably let this pass. If it's from later, then technically the breaking change was in that dependency update.

@LukasTy LukasTy Jul 30, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been bumped quite recently as the release is somewhat recent. 🤔
#18169

@Janpot Janpot Aug 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unfortunate. Technically it's a breaking change and needs to be reverted. Pragmatically, for this specific package, I personally wouldn't have a problem of letting it slide. Up to you

@LukasTy LukasTy Aug 5, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pragmatically, for this specific package, I personally wouldn't have a problem of letting it slide. Up to you

Given the package and that it's only relevant on dev environment, I would say that we can let it slide, unless someone finds a problem with it.
I would be fine keeping this version alignment misunderstanding until the next major.

@LukasTy LukasTy added the v9.x label Aug 5, 2025
@oliviertassinari oliviertassinari added the scope: all components Widespread work has an impact on almost all components. label Aug 21, 2025
@github-actions

github-actions Bot commented Sep 20, 2025

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days.

@github-actions github-actions Bot added the stale Inactive for 7 days (issues) or 30 days (PRs); closed after 5 or 15 more days if no update. label Sep 20, 2025
@LukasTy LukasTy enabled auto-merge (squash) September 22, 2025 08:29
@LukasTy LukasTy merged commit 5d00115 into mui:master Sep 22, 2025
21 checks passed
@LukasTy LukasTy deleted the fix-codemod-engines-node branch September 22, 2025 08:34
@LukasTy LukasTy removed v9.x stale Inactive for 7 days (issues) or 30 days (PRs); closed after 5 or 15 more days if no update. labels Sep 22, 2025
bernardobelchior pushed a commit to bernardobelchior/mui-x that referenced this pull request Sep 22, 2025
@LukasTy @bernardobelchior
[codemod] Bump engines.node to >=20.19 to align with yargs pack…
71aeaae 
…age (mui#18979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Janpot Janpot Janpot approved these changes

Assignees

@LukasTy LukasTy

Labels

breaking change Introduces changes that are not backward compatible. package: codemod Specific to codemod. scope: all components Widespread work has an impact on almost all components. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LukasTy @mui-bot @Janpot @oliviertassinari