Open
Conversation
dorin-iancu
reviewed
Feb 18, 2025
dorin-iancu
reviewed
Feb 20, 2025
dorin-iancu
reviewed
Feb 25, 2025
Comment on lines
+151
to
+161
| if total_farm_incentive > BigUint::zero() { | ||
| let total_farm_vote = self.farm_votes_for_week(farm_id, week).get(); | ||
| let user_incentive = | ||
| &total_farm_incentive * &user_vote.vote_amount / &total_farm_vote; | ||
|
|
||
| user_payments.push(EsdtTokenPayment::new( | ||
| incentive_token.clone(), | ||
| 0, | ||
| user_incentive, | ||
| )); | ||
| } |
Contributor
There was a problem hiding this comment.
De nesting:
if total_farm_incentive == 0 {
continue;
}
// rest of the code here
psorinionut
changed the base branch from
governance-v2-with-timestamp
to
feat/claim-farm-undistributed-rewards
psorinionut
changed the base branch from
feat/claim-farm-undistributed-rewards
to
main
* MEX Governance top farms functionality * code updates & further unit tests * top farms SC fixes & new unit tests * updated github actions * fix after review: code denesting
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from 982e32c to 80522e0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical specs
https://docs.google.com/document/d/17zCN3XQJOy33NQ_kNyiXE7Ve8d_fLVcq2NR7R2BhIEc/edit?usp=sharing