Timestamp based exchange SCs#1032
Merged
psorinionut merged 20 commits intorc/supernova-updatesfrom Jan 17, 2026
Merged
Conversation
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from 7576adb to 75dd4cb
|
dorin-iancu
reviewed
Aug 11, 2025
| } | ||
|
|
||
| fn get_amount_apr_bounded(&self, amount: &BigUint) -> BigUint { | ||
| fn get_amount_apr_bounded(&self, amount: &BigUint, division_safety: &BigUint) -> BigUint { |
Contributor
There was a problem hiding this comment.
Doesn't adding div_safety here mess up all the calculations?
Contributor
Author
There was a problem hiding this comment.
Indeed, it affects the computations in the unit tests, but it doesn't mean it isn't correct. Furthermore, it is even more accurate to use the division safety constant, so that's why we chose this approach and updated the unit tests.
…tion-logic-update Farm Staking supernova migration logic update
claudiulataretu
requested changes
Dec 9, 2025
| let per_block_reward_amount: BigUint<Self::Api> = per_block_reward_amount_mapper.take(); | ||
| let last_reward_nonce = last_reward_block_nonce_mapper.take(); | ||
|
|
||
| require!( |
Collaborator
There was a problem hiding this comment.
This should not be a require. For farms that would not produce rewards anymore the upgrade would fail. It should check for the produce rewards flag just to aggregate remaining rewards per block. Otherwise it should do nothing but still do the upgrade
dex/farm/src/lib.rs
Outdated
| let per_block_reward_amount: BigUint<Self::Api> = per_block_reward_amount_mapper.take(); | ||
| let last_reward_nonce = last_reward_block_nonce_mapper.take(); | ||
|
|
||
| require!( |
Collaborator
There was a problem hiding this comment.
This should not be a require. For farms that would not produce rewards anymore the upgrade would fail. It should check for the produce rewards flag just to aggregate remaining rewards per block. Otherwise it should do nothing but still do the upgrade
farm-staking/farm-staking/src/lib.rs
Outdated
| let current_epoch = self.blockchain().get_block_epoch(); | ||
| self.first_week_start_epoch().set_if_empty(current_epoch); | ||
|
|
||
| // Initialize last_reward_timestamp |
Collaborator
There was a problem hiding this comment.
This should be initialized only when the rewards start
farm-staking/farm-staking/src/lib.rs
Outdated
| let last_reward_nonce = last_reward_block_nonce_mapper.take(); | ||
| let per_block_reward = per_block_reward_amount_mapper.take(); | ||
|
|
||
| require!( |
Collaborator
There was a problem hiding this comment.
This should not be a require. For farms that would not produce rewards anymore the upgrade would fail. It should check for the produce rewards flag just to aggregate remaining rewards per block. Otherwise it should do nothing but still do the upgrade
claudiulataretu
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR will be open towards an rc branch when all pending feat branches will be merged into main.