framework upgrade v0.63#1063
Merged
psorinionut merged 15 commits intorc/supernova-updatesfrom Jan 20, 2026
Merged
Conversation
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from efb6aa7 to 5a64ebe
|
|
|
||
| pub const MAX_PERCENT: u64 = 10_000; | ||
| pub const BLOCKS_IN_YEAR: u64 = 31_536_000 / 6; // seconds_in_year / 6_seconds_per_block | ||
| pub const SECONDS_IN_YEAR: u64 = 31_536_000; |
Contributor
There was a problem hiding this comment.
DurationSeconds instead of u64
dorin-iancu
reviewed
Dec 2, 2025
Comment on lines
-36
to
+37
| .execute_on_dest_context() | ||
| .returns(ReturnsResult) | ||
| .sync_call() |
Contributor
There was a problem hiding this comment.
Why was this even changed? First step towards disaster imo :/
Comment on lines
+110
to
+114
| self.tx() | ||
| .to(action.dest_address.clone()) | ||
| .raw_call(action.endpoint_name.clone()) | ||
| .arguments_raw(ManagedArgBuffer::from(action.arguments.clone())) | ||
| .gas(action.gas_limit) |
Comment on lines
87
to
95
|
|
||
| let first_payment_after = output_payments.get(0); | ||
| let second_payment_after = output_payments.get(1); | ||
| require!( | ||
| first_payment_after.amount >= remove_liq_context.first_token_amount_min, | ||
| output_payments.get(0).amount >= remove_liq_context.first_token_amount_min, | ||
| ERROR_SLIPPAGE_ON_REMOVE | ||
| ); | ||
| require!( | ||
| second_payment_after.amount >= remove_liq_context.second_token_amount_min, | ||
| output_payments.get(1).amount >= remove_liq_context.second_token_amount_min, | ||
| ERROR_SLIPPAGE_ON_REMOVE | ||
| ); |
Contributor
There was a problem hiding this comment.
Unnecessary change? The code was a bit clearer before.
andrei-marinica
requested changes
Dec 2, 2025
| } | ||
|
|
||
| let farming_token_payment = payments.get(0); | ||
| let farming_token_payment = payments.get(0).clone(); |
Contributor
There was a problem hiding this comment.
payments.take(0), there's a remove 4 lines down
| /// | ||
|
|
||
| const MIN_VOTING_DELAY: u64 = 1; | ||
| const MAX_VOTING_DELAY: u64 = 100_800; // 1 Week |
|
|
||
| const MIN_VOTING_DELAY: u64 = 1; | ||
| const MAX_VOTING_DELAY: u64 = 100_800; // 1 Week | ||
| const MIN_VOTING_PERIOD: u64 = 14_400; // 24 Hours |
farm-staking/farm-staking/src/claim_only_boosted_staking_rewards.rs
Outdated
Show resolved
Hide resolved
andrei-marinica
previously approved these changes
Jan 15, 2026
…work-upgrade-0.63
claudiulataretu
requested changes
Jan 20, 2026
| self.accumulated_fees(current_week, &payment_after_burn.token_identifier) | ||
| .update(|amt| *amt += &payment_after_burn.amount); | ||
|
|
||
| self.emit_deposit_swap_fees_event(&caller, current_week, &payment_after_burn); |
Collaborator
There was a problem hiding this comment.
Do you need this in here with the return? Can't we have the old version?
Contributor
Author
There was a problem hiding this comment.
Reverted. Cloned the payment.
claudiulataretu
approved these changes
Jan 20, 2026
andrei-marinica
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.