chore(pq-algorithm-id/ts): phase 4 - release hardening and adoption validation (ENG-1917)#29
chore(pq-algorithm-id/ts): phase 4 - release hardening and adoption validation (ENG-1917)#29
Conversation
Greptile SummaryThis PR completes Phase 4 release hardening for the Key changes:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Consumer imports pq-algorithm-id] --> B{Node / Bundler resolution}
B -- ESM / import --> C["exports['.'].import\n./dist/index.js"]
B -- TypeScript types --> D["exports['.'].types\n./dist/index.d.ts"]
B -- Fallback / CJS --> E["exports['.'].default\n./dist/index.js"]
C --> F[toOid / toJose / toCose / etc.]
D --> F
E --> F
F --> G[pq-oid dependency\npinned at 1.0.2]
G --> H[OID constants\nOID.fromName\nOID.toJOSE / OID.toCOSE]
F -.->|compat.test.ts asserts parity| H
Last reviewed commit: 0a20ebf |
There was a problem hiding this comment.
LGTM — small release-hardening PR with standard exports map, compatibility tests, and doc updates.
Extended reasoning...
Overview
This PR touches four files in the pq-algorithm-id/ts package: a root CHANGELOG entry, a README publish-policy section, the package.json exports field, and a new compat.test.ts file. The scope is narrow and well-defined as "phase 4 release hardening."
Security risks
None. The changes are a package.json exports map (standard Node.js ESM pattern), documentation, and read-only compatibility tests. No auth, crypto logic, or permission-sensitive code is modified.
Level of scrutiny
Low scrutiny is appropriate. The only functional code change is adding an exports field to package.json, which follows established Node.js conventions. The new test file is additive and exercises existing public APIs from both pq-oid and pq-algorithm-id.
Other factors
The inline bug report (README says 0.x.y style pin but actual dependency is 1.0.2) is a valid documentation nit with zero runtime impact. It does not warrant blocking approval. The compatibility tests add meaningful cross-package validation coverage.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d2516ee1a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…alidation (ENG-1917)
Amp-Thread-ID: https://ampcode.com/threads/T-019ce1d8-0c2d-71bf-83c8-432465792d05 Co-authored-by: Amp <amp@ampcode.com>

Summary
Package(s)
Languages
Checklist
biome check,cargo fmt)Related Issues