Bugfix: fix typo for 255 check in regions.go#389
Open
jplauzie wants to merge 6 commits intomumax:3.11.2from
Open
Bugfix: fix typo for 255 check in regions.go#389jplauzie wants to merge 6 commits intomumax:3.11.2from
jplauzie wants to merge 6 commits intomumax:3.11.2from
Conversation
Fixes 2 region>255 typos in regions In regions.Loadfile, this allows region 256 (should be 255), which overflows. Instead of >256 should be >=256. Also changed to NREGIONS instead of 256 for consistency. Also in defRegionId, > to >=
Contributor
|
Thanks for noticing this. In the meantime, I also exposed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there may be two typos in the max number of allowed regions?
In regions.Loadfile() and defRegionId(), it checks if regions are >256. However, I believe this should be >=256? Regions allows 256 regions (0-255), but it should not allow 256.
There is a similar typo in the Voronoi example on the website example page: The line:
"defregion(256, circle(N*c).inverse())".
The Setgeom() command in the example moots it, but 256 actually wraps back to region 0. (This PR does not fix this)