-
-
Notifications
You must be signed in to change notification settings - Fork 57
✨ Add QCO Euler synthesis and fuse-single-qubit-unitary-runs pass
#1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simon1hofmann
wants to merge
22
commits into
main
Choose a base branch
from
decomp/euler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e5280c5
✨ Add Euler decomposition and supporting decomposition primitives
simon1hofmann 01ff591
🐇 Address Rabbit's Comments
simon1hofmann 2c74981
📝 Update factorization documentation in EulerDecomposition
simon1hofmann b7307a3
📝 Update docs and comments
simon1hofmann e978f16
🐇 Address Rabbit's Comments
simon1hofmann d1a85d3
Merge branch 'main' into decomp/euler
denialhaag 1d1ba72
Adapt to new include style
denialhaag 3c7370d
Merge branch 'main' into decomp/euler
simon1hofmann ab35f91
✨ Add QCO UnitaryMatrixOpInterface for compile-time unitary matrices
simon1hofmann 6cb4af2
♻️ Use UnitaryMatrixOpInterface in CtrlOp and InvOp matrix expansion
simon1hofmann abd87fc
♻️ Consolidate QCO Euler decomposition into Euler.h/cpp
simon1hofmann 9c10cb6
✨ Add fuse-single-qubit-unitary-runs pass for Euler resynthesis
simon1hofmann 54ca07d
✅ Add tests for Euler synthesis and fuse-single-qubit-unitary-runs
simon1hofmann 1c01e71
📝 Document fuse-single-qubit-unitary-runs in CHANGELOG
simon1hofmann a92a2b6
🚨 Fix linter warnings
simon1hofmann 577c094
🚨 Fix linter warnings
simon1hofmann 6e7fa7f
🐇 Address Rabbit's comments
simon1hofmann ebc984f
Merge branch 'main' into decomp/euler
simon1hofmann 418b17e
✅ Refactor QCO decomposition tests and update dependencies
simon1hofmann 7da85cd
🎨 Refactor Euler basis handling in QCO transformations
simon1hofmann 5e2cbdc
🎨 Refactor Euler decomposition operations in QCO
simon1hofmann 8eb937c
🎨 Refactor matrix handling and wire start collection in QCO transform…
simon1hofmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to question the added value of the separate header a little bit and because I am curious: Does this really bring us a meaningful advantage in terms of not having to include Eigen (transitively) as often? How often do we only import the QCODialect or QCOInterfaces header, but not the QCOOps header?