Skip to content

🎨 Misc. code quality improvements#547

Merged
burgholzer merged 3 commits into
mainfrom
misc-improvements
Feb 7, 2024
Merged

🎨 Misc. code quality improvements#547
burgholzer merged 3 commits into
mainfrom
misc-improvements

Conversation

@burgholzer

Copy link
Copy Markdown
Member

Description

This PR brings in a couple code quality improvements discovered when working on #538.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added code quality Code quality improvements Core Anything related to the Core library and IR c++ Anything related to C++ code labels Feb 7, 2024
@burgholzer burgholzer self-assigned this Feb 7, 2024
@burgholzer burgholzer enabled auto-merge February 7, 2024 19:19
@codecov

codecov Bot commented Feb 7, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3e105e) 91.2% compared to head (ade870e) 91.2%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #547     +/-   ##
=======================================
- Coverage   91.2%   91.2%   -0.1%     
=======================================
  Files        130     130             
  Lines      13639   13639             
  Branches    2143    2144      +1     
=======================================
- Hits       12444   12442      -2     
- Misses      1195    1197      +2     
Flag Coverage Δ
cpp 90.9% <100.0%> (-0.1%) ⬇️
python 99.5% <ø> (ø)
Files Coverage Δ
src/parsers/qasm3_parser/passes/ConstEvalPass.cpp 84.3% <100.0%> (ø)

... and 1 file with indirect coverage changes

@burgholzer burgholzer merged commit 2141558 into main Feb 7, 2024
@burgholzer burgholzer deleted the misc-improvements branch February 7, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code code quality Code quality improvements Core Anything related to the Core library and IR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant