🐛 ensure typeinfo and vtable information is present for CompoundOperation#548
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
=======================================
- Coverage 91.2% 91.0% -0.2%
=======================================
Files 130 131 +1
Lines 13639 13664 +25
Branches 2144 2150 +6
=======================================
+ Hits 12442 12444 +2
- Misses 1197 1220 +23
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that all the different
Operationsub-classes get a correspondingtypeinfoandvtablesymbol in the compiled binaries. This is important for RTTI when using shared libraries and ensured thatdynamic_casts across library boundaries work as intended. Specifically, theCompoundOperationclass was only defined in a header, which led to the omission of said information. This is fixed by creating a dedicated.cppfile and moving at least one definition there.This was discovered while working on #538 in combination with mqt-ddsim.
Checklist: