🔧 Add Stable ABI checks to cibuildwheel config#824
Conversation
b66b087 to
a7f13fd
Compare
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThe change adds a cibuildwheel configuration override for Python 3.12 wheels that appends an abi3audit validation command to the repair-wheel-command, enabling strict ABI compatibility checks during the wheel build process. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (6)📓 Common learnings📚 Learning: 2026-01-09T17:58:05.212ZApplied to files:
📚 Learning: 2025-10-10T08:10:16.394ZApplied to files:
📚 Learning: 2025-10-10T08:09:54.528ZApplied to files:
📚 Learning: 2025-12-14T16:51:52.504ZApplied to files:
📚 Learning: 2025-12-28T17:13:36.900ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Can we trigger the CD workflow on this PR? |
Done! Judging by the logs of the CD, it also seems to work perfectly. 🤔 |
burgholzer
left a comment
There was a problem hiding this comment.
Done! Judging by the logs of the CD, it also seems to work perfectly. 🤔
Yeah. This one seems safe to go!
Simply adding the suggestion for the revert of the CD change.
Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: Daniel Haag <121057143+denialhaag@users.noreply.github.com>
Description
This PR adds Stable ABI checks to the
cibuildwheelconfig, after I forgot to do that in #817.Checklist:
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.I have added migration instructions to the upgrade guide (if needed).