🎨 Rename Python classes to not violate N801#523
Conversation
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughRenamed the public Python API from snake_case to PascalCase across bindings, stubs, Python package exports, editor code, tests, and build config. Functional behavior and binding implementations are unchanged; only exported symbol names and their usages/types were updated. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@python/mqt/syrec/syrec_editor.py`:
- Around line 931-932: The parameter only_print_signature should be made
keyword-only to avoid boolean-trap (FBT001); update the function/method
signature that currently reads "(inline_stack_entry: QubitInliningStackEntry,
only_print_signature: bool) -> QtGui.QStandardItem" to insert a lone asterisk
before only_print_signature—i.e. "(inline_stack_entry: QubitInliningStackEntry,
*, only_print_signature: bool) -> QtGui.QStandardItem"—so callers must pass
only_print_signature by keyword.
burgholzer
left a comment
There was a problem hiding this comment.
LGTM. Just one clarification.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
This PR renames all Python classes to not violate N801.
Checklist:
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.