Add new accent colours replacing legacy ones#33974
Draft
ajuncosa wants to merge 6 commits into
Draft
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (6)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpdated accent color values in the app and sandbox dark and light config files. Reworked the accent color picker QML to use a Grid and Repeater with explicit selection and navigation handling, and adjusted the related section layout and navigation. Updated the muse subproject reference to a newer commit. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/preferences/qml/MuseScore/Preferences/AccentColorsList.qml`:
- Around line 98-108: The AccentColorsList selection handler is emitting
requests on every checked-state transition instead of only on direct user
action. In AccentColorsList.qml, update the AccentColourButton logic that
currently uses onToggled alongside checked: root.currentColorIndex ===
colorIndex so the accentColorChangeRequested signal is emitted from onClicked
instead, keeping the request tied to a user click and avoiding stale emissions
when other buttons are programmatically unchecked.
- Around line 59-83: `AccentColorsList.qml` is computing `Grid.columns` as a
fractional value when the color list length is odd, which can break the two-row
layout and navigation logic. Update the `columns` binding in the `root` grid
setup to always return an integer, using `Math.floor(root.colors.length / 2)`,
and keep the existing `orderedColorIndices`, `navigationRowOf`, and
`navigationColumnOf` helpers aligned with that integer column count.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6eb7018b-ec8b-4245-bd18-a34b3f5d901f
📒 Files selected for processing (7)
musesandbox/web_sandbox/configs/dark.cfgsandbox/web_sandbox/configs/light.cfgsrc/app/configs/dark.cfgsrc/app/configs/light.cfgsrc/preferences/qml/MuseScore/Preferences/AccentColorsList.qmlsrc/preferences/qml/MuseScore/Preferences/internal/AccentColorsSection.qml
ajuncosa
force-pushed
the
accent-colours
branch
4 times, most recently
from
feae2cd to
23a0754
Compare
ajuncosa
force-pushed
the
accent-colours
branch
2 times, most recently
from
0a419db to
572e079
Compare
…ew theme; Left align accent colours in Preferences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #33863
Related to: musescore/muse_framework#109
Adds new accent colours to the light and dark themes, and displays them in two rows instead of one. This is updated in both the "Preferences" menu, as well as in the first slide of the "Getting started" first-launch dialog (re-design is WIP).