Fix macOS compile of scorecomp.cpp: cast size_t to uint64_t for TextStream#33988
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
In my opinion, this PR in |
|
Merging this PR as a temporary solution (until Casper's PR is merged) |
Resolves: #33987
ScoreComp::compareFileswritessize_tdiff-header values into amuse::TextStream, which has nosize_toverload, so on macOS the call is ambiguous and the unit tests fail to compile. Cast the four values touint64_tat the call sites. No behaviour change (on Linux it already resolved to theuint64_toverload).