[4.7.5] Eliminate xxd and w3c dependencies.#34141
Open
rpatters1 wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
If someone wants to tell me how, we could include removing the mnx exclusion in the build as part of this PR. |
Contributor
|
All that's left of the build exclusion (on both MuseScore/SetupConfigure.cmake Lines 373 to 379 in 0b3600b |
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Could you prefix this PR's title with "[4.7.5]"? |
xxd and w3c dependencies.xxd and w3c dependencies.
Contributor
|
Tkanks. |
Contributor
Author
I added it yesterday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates mnx importexport to use a new version of mnxdom that eliminates the following troublesome dependencies.
xxdutility is no longer required at build time.The change in
mnxdomis a narrow patch to version 3.0 (called 3.0.1) that refactors the build but leaves the rest of the code unchanged. PR #33958 incorporates this cmake change for themainbranch along with many updates tomnxdomfor later mnx schemas, so this PR should not be merged back to themainbranch.Hopefully this eliminates the need to exclude mnx from dev or production builds on any platform.