Skip to content

Reduce QtWidgets dependency#34172

Merged
igorkorsukov merged 4 commits into
musescore:mainfrom
cbjeukendrup:reduce-qtwidgets-dependency
Jul 13, 2026
Merged

Reduce QtWidgets dependency#34172
igorkorsukov merged 4 commits into
musescore:mainfrom
cbjeukendrup:reduce-qtwidgets-dependency

Conversation

@cbjeukendrup

Copy link
Copy Markdown
Collaborator

No description provided.

@cbjeukendrup

Copy link
Copy Markdown
Collaborator Author

The most correct order is probably to first merge this and then musescore/muse_framework#147

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0e23ca07-2d9b-4a39-9e64-995a6895b144

📥 Commits

Reviewing files that changed from the base of the PR and between a37cfe4 and b8732bb.

📒 Files selected for processing (1)
  • src/engraving/api/tests/spanner_tests.cpp
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/engraving/api/tests/spanner_tests.cpp

📝 Walkthrough

Walkthrough

The change replaces QApplication-based clipboard and cursor operations with QGuiApplication equivalents and adds corresponding Qt target dependencies. Engraving API tests now compile ScoreRW utilities, configure their data root, and validate the score spanners property. The previous Plugin API spanner test is removed from the general engraving spanner tests.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing entirely, so it does not satisfy the required template sections or checklist items. Add the required template sections: issue reference, short motivation, and the checklist items with the applicable boxes checked.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: reducing QtWidgets usage by switching several GUI calls to QtGui/Qml-friendly alternatives.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/engraving/api/tests/spanner_tests.cpp`:
- Around line 72-73: Replace the tautological EXPECT_GE check in the spanner
test with a meaningful upper-bound assertion using score->ntracks(), such as
verifying track is less than the score’s track count. Keep the existing
diagnostic identifying the spanner index.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bc1f6e29-3e48-4de3-8c5e-823452e43b08

📥 Commits

Reviewing files that changed from the base of the PR and between 83bc55b and a37cfe4.

📒 Files selected for processing (10)
  • src/appshell/qml/MuseScore/AppShell/aboutmodel.cpp
  • src/engraving/api/tests/CMakeLists.txt
  • src/engraving/api/tests/environment.cpp
  • src/engraving/api/tests/spanner_tests.cpp
  • src/engraving/tests/spanners_tests.cpp
  • src/notation/CMakeLists.txt
  • src/notation/internal/notationinteraction.cpp
  • src/notationscene/qml/MuseScore/NotationScene/CMakeLists.txt
  • src/notationscene/qml/MuseScore/NotationScene/tests/CMakeLists.txt
  • src/preferences/qml/MuseScore/Preferences/preferencesmodel.cpp
💤 Files with no reviewable changes (1)
  • src/engraving/tests/spanners_tests.cpp

Comment thread src/engraving/api/tests/spanner_tests.cpp Outdated
@igorkorsukov igorkorsukov merged commit 2310e02 into musescore:main Jul 13, 2026
14 checks passed
@cbjeukendrup cbjeukendrup deleted the reduce-qtwidgets-dependency branch July 13, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants