Reduce QtWidgets dependency#34172
Conversation
to keep Qt::Qml dependency out of engraving_tests
|
The most correct order is probably to first merge this and then musescore/muse_framework#147 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe change replaces QApplication-based clipboard and cursor operations with QGuiApplication equivalents and adds corresponding Qt target dependencies. Engraving API tests now compile ScoreRW utilities, configure their data root, and validate the score spanners property. The previous Plugin API spanner test is removed from the general engraving spanner tests. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/engraving/api/tests/spanner_tests.cpp`:
- Around line 72-73: Replace the tautological EXPECT_GE check in the spanner
test with a meaningful upper-bound assertion using score->ntracks(), such as
verifying track is less than the score’s track count. Keep the existing
diagnostic identifying the spanner index.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bc1f6e29-3e48-4de3-8c5e-823452e43b08
📒 Files selected for processing (10)
src/appshell/qml/MuseScore/AppShell/aboutmodel.cppsrc/engraving/api/tests/CMakeLists.txtsrc/engraving/api/tests/environment.cppsrc/engraving/api/tests/spanner_tests.cppsrc/engraving/tests/spanners_tests.cppsrc/notation/CMakeLists.txtsrc/notation/internal/notationinteraction.cppsrc/notationscene/qml/MuseScore/NotationScene/CMakeLists.txtsrc/notationscene/qml/MuseScore/NotationScene/tests/CMakeLists.txtsrc/preferences/qml/MuseScore/Preferences/preferencesmodel.cpp
💤 Files with no reviewable changes (1)
- src/engraving/tests/spanners_tests.cpp
No description provided.