Fix musicXML imports containing start-end repeat barlines from Noteflight#34187
Fix musicXML imports containing start-end repeat barlines from Noteflight#34187ajuncosa wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughMusicXML barline classification now receives the exporter software from pass 1. For NoteFlight files, a 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ight Backport of musescore#34187 Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
…ight Backport of musescore#34187 Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
…ight Backport of musescore#34187 Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
…ight Backport of musescore#34187 Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
Resolves: #34139
When combined start-end repeat barlines are present (:||:), scores exported from Noteflight seem to contain
barlineelements that have bothlight-heavybar-style, together withforwardrepeat direction, to signify the start repeat. This was not being recognised as a valid barline type. This PR adds a specific handling for this case.