Skip to content

Fix musicXML imports containing start-end repeat barlines from Noteflight#34187

Open
ajuncosa wants to merge 2 commits into
musescore:mainfrom
ajuncosa:musicxml-start-repeat
Open

Fix musicXML imports containing start-end repeat barlines from Noteflight#34187
ajuncosa wants to merge 2 commits into
musescore:mainfrom
ajuncosa:musicxml-start-repeat

Conversation

@ajuncosa

Copy link
Copy Markdown
Contributor

Resolves: #34139

When combined start-end repeat barlines are present (:||:), scores exported from Noteflight seem to contain barline elements that have both light-heavy bar-style, together with forward repeat direction, to signify the start repeat. This was not being recognised as a valid barline type. This PR adds a specific handling for this case.

@ajuncosa ajuncosa requested a review from miiizen July 13, 2026 16:38
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3f485da2-93e7-48a1-bf71-025232de5dca

📥 Commits

Reviewing files that changed from the base of the PR and between 9beeb79 and ddd88d3.

📒 Files selected for processing (3)
  • src/importexport/musicxml/tests/data/testNoteflightStartRepeatBarline.xml
  • src/importexport/musicxml/tests/data/testNoteflightStartRepeatBarline_ref.mscx
  • src/importexport/musicxml/tests/musicxml_tests.cpp

📝 Walkthrough

Walkthrough

MusicXML barline classification now receives the exporter software from pass 1. For NoteFlight files, a light-heavy barline with a forward repeat is classified as BarLineType::START_REPEAT. New fixtures and an import test cover this behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description has the issue link and summary, but it omits most of the required template checklist and details. Fill out the repository template checklist and add the missing implementation, testing, and commit-purpose details.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: fixing Noteflight MusicXML start-repeat import handling.
Linked Issues check ✅ Passed The PR addresses #34139 by recognizing Noteflight start-repeat barlines and adds a test covering the import case.
Out of Scope Changes check ✅ Passed The code changes and new fixtures stay focused on the Noteflight start-repeat import bug and its test coverage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 14, 2026
…ight

Backport of musescore#34187

Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 14, 2026
…ight

Backport of musescore#34187

Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 14, 2026
…ight

Backport of musescore#34187

Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 14, 2026
…ight

Backport of musescore#34187

Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[musicXML] Start repeat element doesn't import into mscz score

3 participants