[DockWindow v2] CI. Enabled KDDockWidgets v2 by default

[Eism]

After fixing critical bugs, I think we are ready to move to v2

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated the dockwidgets_v2 default from OFF to ON for manual and reusable workflow inputs across the build-all, Linux, macOS, and Windows workflows. Enabled the dockwidgets_v2 CMake module and updated the muse subproject reference to a new commit.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is too brief and omits the required issue reference, summary, and checklist items from the template.	Add the issue reference, a short change summary, and complete the required checklist items from the PR template.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states that KDDockWidgets v2 is enabled by default in CI.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CMakeLists.txt`:
- Line 195: Update the MUSE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2 setting so it
defaults to ON only when the variable is not already defined, preserving
explicit OFF values passed by ninja_build.sh. Use a NOT DEFINED guard or an
equivalent cache default around this setting.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 690ca906-6ab5-4c2d-a64f-67b011771904

📥 Commits

Reviewing files that changed from the base of the PR and between 7299c85 and d96d4d1.

📒 Files selected for processing (6)

• .github/workflows/build_all.yml
• .github/workflows/build_linux.yml
• .github/workflows/build_macos.yml
• .github/workflows/build_windows.yml
• CMakeLists.txt
• muse

🚧 Files skipped from review as they are similar to previous changes (4)

• muse
• .github/workflows/build_all.yml
• .github/workflows/build_windows.yml
• .github/workflows/build_macos.yml

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

rg -n -C3 'dockwidgets_v2|MUSE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2' CMakeLists.txt buildscripts .github/workflows

Repository: musescore/MuseScore

Length of output: 10854

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== CMake context ==\n'
sed -n '180,220p' CMakeLists.txt

printf '\n== Linux build script ==\n'
sed -n '1,140p' buildscripts/ci/linux/build.sh

printf '\n== macOS build script ==\n'
sed -n '1,100p' buildscripts/ci/macos/build.sh

printf '\n== Windows build script ==\n'
sed -n '1,80p' buildscripts/ci/windows/build.bat

printf '\n== Search for direct CMake -D forwarding ==\n'
rg -n -C2 'MUSE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2|dockwidgets_v2|cmake .* -D| -D[Mm]USE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2' buildscripts .github/workflows CMakeLists.txt

Repository: musescore/MuseScore

Length of output: 19364

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== Variable usage ==\n'
rg -n -C3 'MUSE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2|MUSESCORE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2|dockwidgets_v2' . --glob '!build*' --glob '!**/node_modules/**'

printf '\n== SetupConfigure file candidates ==\n'
fd -a 'SetupConfigure*' .

printf '\n== SetupConfigure outline if present ==\n'
for f in $(fd -a 'SetupConfigure*' .); do
  printf '\n--- %s ---\n' "$f"
  wc -l "$f"
  sed -n '1,220p' "$f"
done

Repository: musescore/MuseScore

Length of output: 9081

---

Preserve explicit OFF overrides. ninja_build.sh forwards MUSESCORE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2 as -DMUSE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2=..., so the unconditional set(MUSE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2 ON) at CMakeLists.txt:195 shadows a requested OFF. Guard it with if(NOT DEFINED ...) or switch to a cache default.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CMakeLists.txt` at line 195, Update the
MUSE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2 setting so it defaults to ON only when
the variable is not already defined, preserving explicit OFF values passed by
ninja_build.sh. Use a NOT DEFINED guard or an equivalent cache default around
this setting.