Skip to content

[MusicXML] Fix mapping to AccidentalType#34251

Open
rettinghaus wants to merge 1 commit into
musescore:mainfrom
rettinghaus:xml/accidentalfix
Open

[MusicXML] Fix mapping to AccidentalType#34251
rettinghaus wants to merge 1 commit into
musescore:mainfrom
rettinghaus:xml/accidentalfix

Conversation

@rettinghaus

Copy link
Copy Markdown
Contributor

natural-sharp and natural-flat were not imported correctly.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e761e76b-235e-46ad-af34-e62a6ee8a50b

📥 Commits

Reviewing files that changed from the base of the PR and between d307a2b and 49b95eb.

📒 Files selected for processing (1)
  • src/importexport/musicxml/internal/shared/musicxmlsupport.cpp

📝 Walkthrough

Walkthrough

Corrects musicXmlString2accidentalType so natural-sharp maps to NATURAL_SHARP and natural-flat maps to NATURAL_FLAT instead of the plain sharp and flat accidental types.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too brief and omits required template sections like the issue reference and checklist items. Add the required template content: issue reference, short motivation, and the checklist items, including CLA, testing, and unit test status.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the MusicXML AccidentalType mapping fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants