Fix missing transitive rpath for fetched dependencies on macOS#31
Closed
cbjeukendrup wants to merge 1 commit into
Closed
Fix missing transitive rpath for fetched dependencies on macOS#31cbjeukendrup wants to merge 1 commit into
cbjeukendrup wants to merge 1 commit into
Conversation
_bd_relocatable_macos never received depends_prefixes, unlike its Linux counterpart _bd_relocatable_elf, so a fetched dependency's own dylib never got an rpath entry for its own dependencies' lib directories. Any binary linking only the top-level dependency (not its transitive shared-lib dependencies) would then fail to load at runtime with a dyld "Library not loaded" error, since neither the binary nor the dependency's dylib recorded where to find it. Mirror the existing patchelf-based Linux logic: add install_name_tool -add_rpath calls using @loader_path-relative paths to each dependency prefix's lib directory.
Collaborator
Author
|
@kryksyh Would you mind taking a look? |
Collaborator
|
@cbjeukendrup thank you! merged via #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an AI-assisted fix for an issue on macOS, where builds failed to run because they failed to find libpng, a transitive dependency of freetype.
_bd_relocatable_macos never received depends_prefixes, unlike its
Linux counterpart _bd_relocatable_elf, so a fetched dependency's own
dylib never got an rpath entry for its own dependencies' lib
directories. Any binary linking only the top-level dependency (not its
transitive shared-lib dependencies) would then fail to load at
runtime with a dyld "Library not loaded" error, since neither the
binary nor the dependency's dylib recorded where to find it.
Mirror the existing patchelf-based Linux logic: add
install_name_tool -add_rpath calls using @loader_path-relative paths
to each dependency prefix's lib directory.