Skip to content

Append default suffix when saving/exporting with a single filter #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denisfalqueto wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

Append default suffix when saving/exporting with a single filter #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions framework/interactive/internal/interactive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,19 @@ static UriQuery makeSelectFileQuery(FileDialogMode mode, const std::string& titl
q.set("folder", QUrl::fromLocalFile(current.toQString()).toString().toStdString());
} else if (mode == FileDialogMode::SaveFile) {
q.set("currentFile", QUrl::fromLocalFile(current.toQString()).toString().toStdString());

// Some Linux native/portal dialogs don't auto-append the extension when the user
// doesn't type one, which then leaves the caller without a way to pick the right
// writer. Only do this when there is a single filter on offer: some callers (e.g.
// "Save As" with the experimental uncompressed-folder option) present more than one
// filter, where a global default suffix would be applied regardless of the filter
// the user actually selected, defeating the alternate option.
if (filter.size() == 1) {
std::string suffix = io::suffix(current);
if (!suffix.empty()) {
q.set("defaultSuffix", suffix);
}
}
}

return q;
Expand Down