Skip to content

update deps ref #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kryksyh merged 1 commit into from
Jul 10, 2026
Merged

update deps ref #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildscripts/muse_deps.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
bcf01b071dc093de6ebe824711180958a230186f
adcefed921921cb090110b4a71a91966c1306889

@coderabbitai coderabbitai Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

uncrustify.cmake won't pick up this ref update on pre-existing checkouts.

In tools/codestyle/uncrustify.cmake:5-30, the file(STRINGS), git fetch, and git checkout are all inside if(NOT EXISTS "${EXTDEPS_DIR}/buildtools/manifest.cmake"). When the muse_deps directory already exists from a prior build, the new hash is never read or fetched, so the uncrustify toolchain stays on the old revision. In contrast, SetupDependencies.cmake reads and fetches unconditionally, so the main dependencies update correctly — leading to a potential mismatch between the two.

This is a pre-existing issue, but it directly affects whether this ref update takes effect for the uncrustify path. Consider moving the fetch/checkout outside the existence check in uncrustify.cmake to mirror SetupDependencies.cmake's behavior.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@buildscripts/muse_deps.ref` at line 1, Update the uncrustify dependency setup
so the muse_deps ref is read, fetched, and checked out even when
EXTDEPS_DIR/buildtools/manifest.cmake already exists. In
tools/codestyle/uncrustify.cmake, keep only initial directory/setup logic inside
the existence guard and move the file(STRINGS), git fetch, and git checkout
operations outside it, matching SetupDependencies.cmake behavior.

Loading