feat: add explicit group_head_ids selection and search filter to ExportRMGroupsRequest#24
Merged
ilramdhan merged 1 commit intomutugading:mainfrom May 4, 2026
Conversation
…rtRMGroupsRequest
There was a problem hiding this comment.
Pull request overview
This PR expands ExportRMGroupsRequest in finance/v1/rm_group.proto to support additional export-selection capabilities for RM Groups, enabling either broad exports (all/filtered) or explicitly selected groups by ID.
Changes:
- Added
group_head_idsto explicitly select which RM groups to export. - Added
searchto allow optional code/name filtering for RM group exports. - Updated request documentation to describe the intended export modes and precedence.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| finance/v1/rm_group.proto | Extends RM group export request with explicit ID selection + search filter, and updates request docs accordingly. |
| finance/v1/rm_cost.proto | Included in PR metadata as modified (not shown in provided diff). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+734
to
+739
| // ExportRMGroupsRequest filters the export. Three mutually-exclusive modes: | ||
| // | ||
| // - All groups: leave both filters unset (default). | ||
| // - Filtered: set `active_filter` (and/or `search`) to narrow the set. | ||
| // - Selected: pass an explicit list of group_head_ids; all other filters | ||
| // are ignored. |
Comment on lines
+743
to
+749
| // Optional explicit group selection. When non-empty, only these groups | ||
| // are exported (overrides `active_filter` and `search`). | ||
| repeated string group_head_ids = 2 [(buf.validate.field).repeated = { | ||
| items: { | ||
| string: {uuid: true} | ||
| } | ||
| }]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
ExportRMGroupsRequestmessage in thefinance/v1/rm_group.protofile to support more flexible export modes for RM groups. The request can now operate in three mutually-exclusive modes: exporting all groups, filtering by active status or search, or exporting a specific set of groups by their IDs.Change Type
Proto Files Changed
finance/v1/rm_cost.protofinance/v1/rm_group.protoChanges Made
Enhancements to export filtering:
group_head_idsfield to allow explicit selection of groups to export, which overrides other filters when set. This field is validated to contain UUID strings.ExportRMGroupsRequestto clarify the three export modes and the precedence of the newgroup_head_idsfield overactive_filterandsearch.searchfield for optional code/name filtering, with a maximum length validation.Pre-merge Checklist
buf format -wappliedbuf lintpassesbuf breakingpassesImpact Assessment