fix(rm-cost): add V2 valuation and marketing flags for improved flag resolution in rm_cost.proto#26
Merged
ilramdhan merged 1 commit intomutugading:mainfrom May 5, 2026
Conversation
…resolution in rm_cost.proto
There was a problem hiding this comment.
Pull request overview
This PR extends the finance RM cost protobuf so RMCost can expose the resolved V2 valuation/marketing flags after AUTO fallback, making the computed branch more visible to API consumers.
Changes:
- Added
valuation_flag_usedtoRMCostfor the resolved valuation flag. - Added
marketing_flag_usedtoRMCostfor the resolved marketing flag. - Documented the intended AUTO fallback behavior for both new fields.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| optional double pr_rate = 38; | ||
| // V2: Valuation flag actually used after AUTO cascade (CL→SL→FL fallback). | ||
| // Equals valuation_flag when explicit, or the resolved choice when AUTO. | ||
| RMValuationFlag valuation_flag_used = 39; |
Comment on lines
+127
to
+129
| RMValuationFlag valuation_flag_used = 39; | ||
| // V2: Marketing flag actually used after AUTO cascade (SP→PP→FP fallback). | ||
| RMMarketingFlag marketing_flag_used = 40; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds two new fields to the
RMCostmessage in thefinance/v1/rm_cost.protofile to clarify which valuation and marketing flags are actually used after resolving any "AUTO" settings. This helps make downstream logic and data analysis more explicit and reliable.Change Type
Proto Files Changed
common/v1/common.protofinance/v1/uom.protoChanges Made
Enhancements to
RMCostmessage:valuation_flag_usedfield to record the resolved valuation flag after applying the AUTO cascade logic (CL→SL→FL fallback).marketing_flag_usedfield to record the resolved marketing flag after applying the AUTO cascade logic (SP→PP→FP fallback).Breaking Change Check
Is this a breaking change?
buf breakingpassesPre-merge Checklist
buf format -wappliedbuf lintpassesbuf breakingpassesImpact Assessment