fix: resolve TypeScript errors with moduleResolution nodenext and skipLibCheck false#1313
Open
R-Delfino95 wants to merge 10 commits intomuxinc:mainfrom
Open
fix: resolve TypeScript errors with moduleResolution nodenext and skipLibCheck false#1313R-Delfino95 wants to merge 10 commits intomuxinc:mainfrom
R-Delfino95 wants to merge 10 commits intomuxinc:mainfrom
Conversation
|
@R-Delfino95 is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Jerricho93
approved these changes
Apr 28, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 289670b. Configure here.
…e loops and improve error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #1299
mux-embed'stype declarations intoplayback-core/src/vendor/mux-embed.ts. TypeScript compiles this intodist/types/vendor/mux-embed.d.tsand emits a correct relative reference path for consumers.vendor:typesnpm script (scripts/vendor-mux-embed-types.mjs) that copies the types directly fromnode_modules/mux-embed/dist/types/mux-embed.d.ts. It's hooked intoprebuild:typesso it runs automatically on every build — keeping the vendored copy in sync with whatever version ofmux-embedis installed.@types/google_interactive_media_ads_typestodependenciesinmux-video./// <reference path>frommux-video/src/ads/index.ts— it's no longer needed since playback-core's vendored reference propagates transitively.Note
Medium Risk
Medium risk because it changes how
@mux/playback-coreships TypeScript declarations (new vendoredmux-embedtypes and a pre-build generation step), which can affect downstream type resolution and builds.Overview
Fixes NodeNext/
skipLibCheck=falseTypeScript build failures by vendoringmux-embedtype declarations into@mux/playback-coreand updatingsrc/types.tsto reference the vendored file instead ofnode_modules.Adds a
vendor:typesscript (run automatically viaprebuild:types) to copymux-embed’s.d.tsintosrc/vendor, and ignores the generated vendor directory in ESLint/Prettier. Also adjusts packaging dependencies: moves@types/google_interactive_media_ads_typestomux-videoruntimedependencies, removes an unneeded/broken triple-slash reference inmux-videoads entry, and tweaks a couple dependency version ranges in the lockfile.Reviewed by Cursor Bugbot for commit 98fe70d. Bugbot is set up for automated code reviews on this repo. Configure here.