Conversation
mvo5
left a comment
mvo5
left a comment
There was a problem hiding this comment.
Thanks! This looks very nice, a few quick comments inline, I thnk the -o is the only critical one though.
| if (pipe (sigterm_unix_signal_pipe_fds) != 0) { | ||
| g_warning ("Could not setup pipe, errno=%d", errno); | ||
| return 1; | ||
| exit(1); |
There was a problem hiding this comment.
This feels slightly not-nice (to exit here hard instead of returning), but I guess its the only way(?) if applicationActivate is void :( oh well :)
There was a problem hiding this comment.
How about removing this code and just rely on Gtk?
There was a problem hiding this comment.
I like the idea if it does what this code from 20y ago does I'm +100 :) Can you please double check that we can remove it (and if so just do it)?. I also merged the other PR so this can now be rebased into a single commit. Thanks!
|
|
||
| RPackageLister *packageLister = new RPackageLister(); | ||
| RGMainWindow *mainWindow = new RGMainWindow(packageLister, "main"); | ||
| RGMainWindow *mainWindow = new RGMainWindow(GTK_APPLICATION(app), packageLister, "main"); |
There was a problem hiding this comment.
This is pre-existing so feel free to ignore but I wonder if construcuting the packageLister and mainWindow should happen after the trick around putting an existing synaptic into the foreground (feel free to ignore)
andy128k
force-pushed
the
gtk-application
branch
from
3ee22c9 to
c987002
Compare
andy128k
force-pushed
the
gtk-application
branch
from
c987002 to
6c581ea
Compare
2 participants
No description provided.