WIP: Addition of a timer to virustotal checks#593
Open
nimrod-a wants to merge 3 commits intomvt-project:mainfrom
Open
WIP: Addition of a timer to virustotal checks#593nimrod-a wants to merge 3 commits intomvt-project:mainfrom
nimrod-a wants to merge 3 commits intomvt-project:mainfrom
Conversation
Contributor
|
Looks good! Feel free to ping here when it's ready for a review and we'll get it merged |
Collaborator
|
Hey @nimrod-a are you still working on this? :) |
Contributor
Author
|
The feature was pretty much done. I will test it again this week and give an update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress to add a
-d/--delayoption to thedownload-apkscommand, which enables the throttling of VirusTotal queries.Inspired by virustotal-search.py, it has a default value of 16 seconds and utilizes
time.sleepto add a delay between each VT API request.This can be useful when using the free VT API, as checks are limited to 4 queries a minute and 500 a day.
While I have run
pyteston the commits, I have not tested the changes using an actual backup / packages yet.I will give an update once that is done!