Abort analysis and warn user when backup is encrypted#772
Open
Abort analysis and warn user when backup is encrypted#772
Conversation
When `check-backup` is run against an encrypted backup, Manifest.db cannot be opened as a plain SQLite database. Previously this caused a flood of confusing "file is not a database" errors across all modules. Now the Manifest module detects the sqlite3.DatabaseError on its first query and raises a new EncryptedBackupError. This exception propagates out of run_module() and is caught in Command.run(), which logs a clear critical message instructing the user to decrypt the backup first with `mvt-ios decrypt-backup`, then stops the analysis immediately. Fixes #769
Contributor
|
Contributor
|
Awesome! It works great for me and protects from so much confusion when starting with MVT 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #769
Summary
EncryptedBackupErrorexception tomvt.common.moduleManifest.run(), catchessqlite3.DatabaseErrorwhen queryingManifest.db— the error that occurs when the database is encrypted — and raisesEncryptedBackupErrorCommand.run(), catchesEncryptedBackupErrorfromrun_module(), logs a clear critical message telling the user to decrypt the backup first usingmvt-ios decrypt-backup, and stops the entire analysis immediatelyPreviously, running
check-backupagainst an encrypted backup would silently continue through all modules, producing a flood of confusing "file is not a database" errors. Now the analysis aborts early with a single actionable message.