Add support for OpenSSH certificates, resolve #31

[luigidemasi]

No description provided.

[norrisjeremy]

1. Can you run mvn formatter:format to ensure that everything is formatted correctly?
2. Does this support SSH certs for host keys? If not, we need to add support for that too, as I'm opposed to only adding support SSH certs for user pubkey auth, w/o also adding support for SSH certs as host keys as well at the same time.

[davsclaus]

@norrisjeremy is there more feedback to this, as it would be nice to get to the finish line, thanks

[norrisjeremy]

@norrisjeremy is there more feedback to this, as it would be nice to get to the finish line, thanks

1. None of my earlier feedback appears to have actually been incorporated: the PR author simply marked them all as resolved w/o making any of the suggested changes.
2. To quote part of my earlier review: "Does this support SSH certs for host keys? If not, we need to add support for that too, as I'm opposed to only adding support SSH certs for user pubkey auth, w/o also adding support for SSH certs as host keys as well at the same time."

[luigidemasi]

@norrisjeremy is there more feedback to this, as it would be nice to get to the finish line, thanks

1. None of my earlier feedback appears to have actually been incorporated: the PR author simply marked them all as resolved w/o making any of the suggested changes.
2. To quote part of my earlier review: "Does this support SSH certs for host keys? If not, we need to add support for that too, as I'm opposed to only adding support SSH certs for user pubkey auth, w/o also adding support for SSH certs as host keys as well at the same time."

Hi @norrisjeremy, thanks for following up. I marked the comments as resolved on GitHub because I had already addressed them locally and didn’t want to lose track of your suggestions. I’m currently adding support for host keys as well (it’s nearly finished) and I’ll push everything together in the next update. Please let me know if you have any additional suggestions in the meantime.

[norrisjeremy]

Hi @norrisjeremy, thanks for following up. I marked the comments as resolved on GitHub because I had already addressed them locally and didn’t want to lose track of your suggestions. I’m currently adding support for host keys as well (it’s nearly finished) and I’ll push everything together in the next update. Please let me know if you have any additional suggestions in the meantime.

Hi @luigidemasi,

Great, thanks! We are excited to have someone step up and contribute this work!

Thanks,
Jeremy

[luigidemasi]

@norrisjeremy

2. Does this support SSH certs for host keys? If not, we need to add support for that too, as I'm opposed to only adding support SSH certs for user pubkey auth, w/o also adding support for SSH certs as host keys as well at the same time.

I added the support for Host Certificate, let me know wdyt.

[davsclaus]

Great to see progress on this one. If we are getting close to the finish line it would be good to do the last review and update the reported findings so fingers crossed we can get this merged and released. Thank you.

[norrisjeremy]

Great to see progress on this one. If we are getting close to the finish line it would be good to do the last review and update the reported findings so fingers crossed we can get this merged and released. Thank you.

I probably won't have time to start reviewing this again until next week.

[davsclaus]

Great to see progress on this one. If we are getting close to the finish line it would be good to do the last review and update the reported findings so fingers crossed we can get this merged and released. Thank you.

I probably won't have time to start reviewing this again until next week.

Thanks for the update, no problem. Just glad we are on path to the goal line.

[davsclaus]

Sorry to bother - but would be good to get this reviewed

[norrisjeremy]

Sorry to bother - but would be good to get this reviewed

HI @davsclaus,

Yes, I haven't forgotten, I will try to review it when I have some time available.

Thanks,
Jeremy

[norrisjeremy]

Just a few initial comments, I still have a lot left to review.

[norrisjeremy]

Looks like we need to run mvn formatter:format?

[luigidemasi]

@norrisjeremy, @mwiede

this PR is open since September 2025. We're almost in April 2026 and every week there's a new comment about changing a log level, removing an empty line, reordering an import, checking what OpenSSH does for this edge case. I've addressed every round within days but there's always something new the week after.

I'm tired of this. The OpenSSH behavior questions are fair, but they could have been raised months ago, not one at a time spread across half a year.

So please review the whole thing, and tell me everything that's left. All of it, at once. I'll fix it. Then we merge. I'm not going to keep going back and forth on cosmetic stuff until September 2026.

[sonarqubecloud]

Quality Gate passed

Issues
245 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mwiede]

@luigidemasi I am basically fine with the PR and I am about to merge it. I even let Claude Code review it, and it does't have any critical findings.
@norrisjeremy can you please give your approval

[norrisjeremy]

Hi @luigidemasi,

Thank you for dedication and effort towards implementing this feature, and your patience working with us during the review process!

@mwiede, I think we may want to increment the major version to 2.28 since this is a significant feature.

Thanks!
Jeremy