Skip to content

Fix: reuse Header instance in Cron formatter #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zigzagdev wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: reuse Header instance in Cron formatter #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d65dbc0
fix: reuse Header instance
zigzagdev Jan 14, 2026
bd3c9ac
feat: add new tests
zigzagdev Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Formatter/Cron.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ class Cron

public function header(): Header
{
$this->header = new Header($this);
if ($this->header === null) {
$this->header = new Header($this);
}

return $this->header;
}
Expand Down
21 changes: 21 additions & 0 deletions tests/Formatter/CronTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,25 @@ public function shouldBuildConfiguration(): void

$this->assertEquals($expected, $this->cron->format());
}

/** @test */
public function headerShouldReturnSameInstance(): void
{
$h1 = $this->cron->header();
$h2 = $this->cron->header();

$this->assertSame($h1, $h2);
}

/** @test */
public function headerShouldNotLoseStateWhenCalledMultipleTimes(): void
{
$this->cron->header()->setPath('path')->end();
$this->cron->header()->setMailto('test@example.com')->end();

$output = $this->cron->format();

$this->assertStringContainsString("PATH=path", $output);
$this->assertStringContainsString("MAILTO=test@example.com", $output);
}
}