Skip to content

[#1780] Add Welsh translation for DB form#1784

Open
mdeuk wants to merge 5 commits intomysociety:masterfrom
mdeuk:1780-welsh-reportdb-form
Open

[#1780] Add Welsh translation for DB form#1784
mdeuk wants to merge 5 commits intomysociety:masterfrom
mdeuk:1780-welsh-reportdb-form

Conversation

@mdeuk
Copy link
Copy Markdown
Collaborator

@mdeuk mdeuk commented Sep 5, 2023

Relevant issue(s)

Fixes #1780
Fixes https://github.com/mysociety/whatdotheyknow-private/issues/262
#1775

What does this do?

  1. Reconciles changes for /lib/views/help/contact.html.erb from Signpost data breach form #1775 into Welsh translation.
  2. Adds partial translation for /lib/views/help/report_a_data_breach.html.erb

Why was this needed?

Data breach form was not translated to Welsh.

Implementation notes

The breach form, itself, is only a partial translation, as:

  • the heading, at level 1, is not translated (now rectified)
  • the further information text, and everything following, is not translated
  • related file report_a_data_breach_thank_you.html.erb is not translated

Screenshots

N/A

Notes to reviewer

I had a bit of trouble with Git commits - hopefully all makes sense.

We will need to follow-up on the remaining parts, but this can be done later on.

Adds initial translation for data breach form (diolch, Helo Blod)
@mdeuk mdeuk added the awaiting-review Complete but waiting for review (mainly for pull requests) label Sep 5, 2023
@mdeuk mdeuk marked this pull request as ready for review September 5, 2023 15:54
@mdeuk mdeuk requested a review from Copilot April 8, 2025 10:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

lib/views/help/_contact_form.cy.html.erb:86

  • Rendering the 'help/contact_form' partial within _contact_form.cy.html.erb may lead to unintended recursion if it resolves to the current localized partial. Consider explicitly referencing the non-localized version or ensuring the view lookup selects the intended file.
<%= render :partial => "help/contact_form", :locals => { :form_id => 'writing-help' } %>

lib/views/help/_contact_form.cy.html.erb:166

  • Similar to the earlier render call, this may also trigger recursive rendering if the lookup finds the current localized partial. Verify that the intended (possibly unlocalized) partial is referenced to avoid recursion.
<%= render :partial => "help/contact_form", :locals => { :form_id => 'wdtk' } %>

Comment thread lib/views/help/report_a_data_breach.cy.html.erb Outdated
Comment thread lib/views/help/report_a_data_breach.cy.html.erb Outdated
Comment thread lib/views/help/report_a_data_breach.cy.html.erb Outdated
Update links to ICO guidance, correcting broken link
@mdeuk mdeuk requested a review from Copilot April 11, 2025 21:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread lib/views/help/report_a_data_breach.cy.html.erb Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@mdeuk mdeuk added the data-protection Data Protection and privacy label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review Complete but waiting for review (mainly for pull requests) data-protection Data Protection and privacy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add link to report-a-breach form to /cy/help/contact

2 participants