[#1780] Add Welsh translation for DB form#1784
Open
mdeuk wants to merge 5 commits intomysociety:masterfrom
Open
[#1780] Add Welsh translation for DB form#1784mdeuk wants to merge 5 commits intomysociety:masterfrom
mdeuk wants to merge 5 commits intomysociety:masterfrom
Conversation
Adds initial translation for data breach form (diolch, Helo Blod)
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
lib/views/help/_contact_form.cy.html.erb:86
- Rendering the 'help/contact_form' partial within _contact_form.cy.html.erb may lead to unintended recursion if it resolves to the current localized partial. Consider explicitly referencing the non-localized version or ensuring the view lookup selects the intended file.
<%= render :partial => "help/contact_form", :locals => { :form_id => 'writing-help' } %>
lib/views/help/_contact_form.cy.html.erb:166
- Similar to the earlier render call, this may also trigger recursive rendering if the lookup finds the current localized partial. Verify that the intended (possibly unlocalized) partial is referenced to avoid recursion.
<%= render :partial => "help/contact_form", :locals => { :form_id => 'wdtk' } %>
mdeuk
commented
Apr 11, 2025
mdeuk
commented
Apr 11, 2025
mdeuk
commented
Apr 11, 2025
Update links to ICO guidance, correcting broken link
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #1780
Fixes https://github.com/mysociety/whatdotheyknow-private/issues/262
#1775
What does this do?
/lib/views/help/contact.html.erbfrom Signpost data breach form #1775 into Welsh translation./lib/views/help/report_a_data_breach.html.erbWhy was this needed?
Data breach form was not translated to Welsh.
Implementation notes
The breach form, itself, is only a partial translation, as:
the heading, at level 1, is not translated(now rectified)report_a_data_breach_thank_you.html.erbis not translatedScreenshots
N/A
Notes to reviewer
I had a bit of trouble with Git commits - hopefully all makes sense.
We will need to follow-up on the remaining parts, but this can be done later on.