Draft
Conversation
Sometimes this is breaking for files which have redactions/masks. In the case of some XLSX files text masking of email addresses in the underlying ZIP format meant the Python Excel Analyzer code couldn't decompress the file and analyse the file contents. The patch for the ActiveStorage mirror service is needed for our server deployment as these jobs run on a secondary application instance which doesn't have the raw email on disk, so we have to rely on fetching the S3 mirrored version. This patch should probably be moved elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes this is breaking for files which have redactions/masks.
In the case of some XLSX files text masking of email addresses in the underlying ZIP format meant the Python Excel Analyzer code couldn't decompress the file and analyse the file contents.
The patch for the ActiveStorage mirror service is needed for our server deployment as these jobs run on a secondary application instance which doesn't have the raw email on disk, so we have to rely on fetching the S3 mirrored version. This patch should probably be moved elsewhere.