fix: add types condition to the front of the exports - #30
Open
Andarist wants to merge 1 commit into
Open
Conversation
|
Hi @Andarist! Since this repo is unmaintained, you might want to re-open this PR in the @eslint-community fork https://github.com/eslint-community/regexpp For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org |
Andarist
force-pushed
the
fix/types-condition
branch
2 times, most recently
from
April 30, 2023 13:02
9dddb6a to
6c27878
Compare
|
For people watching this PR: we've already started with our own fork in order to not hold the wider community back anymore: https://github.com/eslint-community/regexpp @mysticatea We would still love to move the original repo to the new @eslint-community though. This PR is released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
typescondition to the front.package.json#exportsare order-sensitive - they are always matched from the top to the bottom. When a match is found then it should be used and no further matching should occur.Right now, the current setup works in TypeScript but it's considered a bug and it should not be relied upon, see the thread and the comment here. For that reason, I would like to fix all popular packages that misconfigured their
exportsthis way so the bug can be fixed in TypeScript.