--patch: Show interactive output#121
Conversation
| repo.git("add", "-u") | ||
| if args.patch: | ||
| repo.git("add", "-p") | ||
| repo.git("add", "-p", nocapture=True) |
There was a problem hiding this comment.
This was also fixed in this #99 (see discussion: #99 (comment)).
That PR has been ready to merge for quite a while. (cc @mystor @Manishearth @krobelus).
There was a problem hiding this comment.
Good to see. Our fixes are effectively the same. They would probably be identical if you were to reorder your commits to put the fix first.
I would typically put the fix first, though (to minimize the bug's lifetime in commits), even as you said in your commit that the mistake becomes obvious after making the argument explicit, which I think is a right response. There is some truth to python -c 'import this' | grep Explicit. However, as soon as all callers are explicit, I think the argument needn't/shouldn't be optional anymore. And as a consideration, if it helps verbosity: The distinction can also be made obligatory by wrapper functions, such as git_interactive() vs git_popen() vs git_silent().
Fixes a current CI failure. Alternatively, lock black to the previous working version (black==21.12b0).
anordal
force-pushed
the
120-patch-interactively
branch
from
60c92b5 to
21112da
Compare
|
This was also fixed by #99 which I've now merged, so marking as closed. Thanks for the patch :-) |
3 participants
Fixes #120