Reduce time of write-schema by at least 5%, work around intermittent test on MacOS#220
Merged
Reduce time of write-schema by at least 5%, work around intermittent test on MacOS#220
write-schema by at least 5%, work around intermittent test on MacOS#220Conversation
We might be able to get rid of the typeclass, and optimise this
Improved by at least 10% according to tests
mzabani
changed the title
mzabani
force-pushed
the
fsync-after-folder-creation
branch
from
1f760e9 to
5b6dbd7
Compare
mzabani
changed the title
mzabani
changed the title
mzabani
force-pushed
the
fsync-after-folder-creation
branch
from
159408b to
2926c51
Compare
mzabani
force-pushed
the
fsync-after-folder-creation
branch
from
2926c51 to
0efdf4e
Compare
mzabani
force-pushed
the
fsync-after-folder-creation
branch
2 times, most recently
from
57bd9b9 to
ab47600
Compare
mzabani
changed the title
write-schema by at least 5%, work around intermittent test on MacOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run test-with-db -- --match "persistRepsToDisk is inverse of readRepsFromDisk"failed intermittently on MacOS.I initially thought this could be that posix doesn't guarantee write-then-read consistency ("thanks" ChatGPT for leading me down that rabbit hole), but then this PR showed it was always the same seeds that failed.
After removing non-ASCII characters from the
Arbitrary ObjNameinstances, these tests stopped failing, so it's a character encoding issue, actually.After trial and error, it became apparent that the
ñcharacter from thatArbitraryinstance is the only problematic character for MacOS (either that or test failures are significantly rarer without that). So it's no longer generated in our tests for MacOS. This is a workaround because I could not fix the issue for good.I'm leaving comments in the code to articles that relate to the issue.
Other than that, some perf improvements after changing the code:
write-schema && verify-schemawent from 34.54 to 32.56 -> at least 5,7% time reduction in write-schema