Open
Conversation
Owner
|
Hi~首先感谢你的 PR。 是什么情况下出现问题呢?可以详细描述一下吗? |
Author
|
new gitalk 中 id 的值单引号格式错误(单引号中嵌套了单引号),在gitalk 初次加载的时候会报错 Not found 。 |
Owner
|
不好意思过了好久了才回复你,有没有报错的截图或者能预览到这个错误的例子啊? |
Author
Owner
|
你说的代码里的这个地方我知道,我看到你的 commit 了。 你是实际遇到有报错呢,还是只是从语义上理解它有问题? 我理解的话, |
Author
|
Jekyll 编译过程中会替换成实际的值,这个的话我倒是没看过。我遇到的问题是,使用gitalk的时候初次加载页面报错 not found ,gitalk加载失败了,然后我看了下这个地方的有语法问题,修改后就加载正常了。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

当只使用gitalk的时候,这个地方的格式错误会导致gitalk加载失败。