Allow specifying custom ALPN for Downloader#242
Open
maackle wants to merge 1 commit into
Open
Conversation
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds ALPN as a parameter to
Downloader::new_with_opts, to allow operation with custom ALPNsBreaking Changes
Use of
Downloader::new_with_optsmust provideiroh_blobs::ALPNas the the new arg.Notes & open questions
This is necessary for use with p2panda, which internally hashes any registered ALPNs with a private "network ID", making it impossible to interoperate protocols across the p2panda boundary using default ALPNs.
Change checklist