fs store: preserve recoverable states and terminate broken observes - #243
Closed
YuniqueUnic wants to merge 1 commit into
Closed
fs store: preserve recoverable states and terminate broken observes#243YuniqueUnic wants to merge 1 commit into
YuniqueUnic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233.
Summary
HashContext::persist()from destructively replacing non-Partialstorage withPoisonedInitial/Loading, emit empty only forNonExisting, and terminate observe forPoisonedThis keeps an empty bitfield meaning “valid entry with no verified data” and uses the existing stream failure path for broken entries, following the design discussion in #214.
Recovery semantics
NonExisting, allowing a normal re-fetch/importPoisonedTests
Verified with:
cargo test --all-features(103 unit passed, 2 ignored; 6 integration passed; 17 doctests passed)cargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --check