feat: Add wasm support to net_diagnostics#93
Open
matheus23 wants to merge 22 commits into
Open
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-services/pr/93/docs/iroh_services/ Last updated: 2026-06-26T08:16:33Z |
dignifiedquire
approved these changes
Jun 25, 2026
Contributor
|
ci seems sad |
Member
Author
|
I'm kind of at a loss as to why the IROH_SERVICES_API_SECRET env var is working for the Wasm check but not the the native one? Is there something about environment overrides that I'm missing in github actions? |
Member
Author
|
Well this was a long fight... Mind taking another small look at this PR @dignifiedquire? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches some
std::time/tokio::timeuse over ton0-futureto enable Wasm support.Also adds an integration test that runs against the n0/dogfood project in production both natively and from node.js with Wasm (via wasm_bindgen_test) to ensure Wasm support stays working.
For that, I added an IROH_SERVICES_API_SECRETS github action secret to this repo and need to pass it through to the test in various ways, thus all the changes to workflow files.
Breaking Changes
None
Change checklist