tests(proto): fix ManyToMany routing#726
Open
flub wants to merge 1 commit into
Open
Conversation
The routes were looking up the connections in the wrong direction, e.g. to send to the server it was checking that the server's interface with matching address could send to the client. Curiously, and luckily, nothing seemed to rely on this odd behaviour. All tests keep passing, including proptests.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/726/docs/noq/ Last updated: 2026-06-27T16:12:10Z |
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5294.0 Mbps | 7894.3 Mbps | -32.9% | 94.0% / 100.0% |
| medium-concurrent | 5324.3 Mbps | 7913.0 Mbps | -32.7% | 93.7% / 98.0% |
| medium-single | 4042.6 Mbps | 4691.6 Mbps | -13.8% | 94.1% / 101.0% |
| small-concurrent | 3814.7 Mbps | 5222.9 Mbps | -27.0% | 99.4% / 153.0% |
| small-single | 3427.5 Mbps | 4713.7 Mbps | -27.3% | 89.4% / 97.3% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3012.6 Mbps | 4027.4 Mbps | -25.2% |
| lan | 782.4 Mbps | 796.4 Mbps | -1.8% |
| lossy | 69.8 Mbps | 69.8 Mbps | ~0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 27.0% slower on average
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The routes were looking up the connections in the wrong direction,
e.g. to send to the server it was checking that the server's
interface with matching address could send to the client.
Curiously, and luckily, nothing seemed to rely on this odd
behaviour. All tests keep passing, including proptests.
Breaking Changes
none
Notes & open questions
n/a
Change checklist