Version for showing Amazon S3 storage#6
Open
shaunakv1 wants to merge 3 commits into
Open
Conversation
…ibraries into vendor/assets
Owner
|
I do not understand something: what links and where to add? I can do a 2013/8/12 Shaunak Vairagare notifications@github.com
Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a version with amazon s3 support using carrierwave.
This looks like a rather big change because I have cleaned up the app/assets dir and moved the library js to vendor/assets. I have also removed the old template code in the gallery/views/show.rb which was no longer being used as the logic was moved to main.js.
Now expecting a merge as this is a different sample, but changes for moving assets to vendor dir and removing stale template code can be safely merged with the original one one.
It would be great if you could add a short link to this project in the original readme pointing out a s3 sample. :)