This repository was archived by the owner on Nov 10, 2017. It is now read-only.
React 0.14#33
Open
lionelB wants to merge 4 commits inton1k0:masterfrom
Open
Conversation
rename js file to jsx remove jsx pragma update project dependencies update to react v0.14 api
Contributor
Author
|
🎂 @n1k0 |
Owner
|
Thanks :) You well deserved a review today o/ |
Owner
There was a problem hiding this comment.
Please format it this way: "indent": [2, 2],
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP still some issue probably due to
<Modal />when usedrenderIntoDocument()other tests are greens !
Do you mind take a look if it is going in the good direction ?