Add option to set more button pressed color#6
Open
pauluhn wants to merge 2 commits inton3d1117:mainfrom
Open
Conversation
Also fix intrinsic size issue on UIKit side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to customize the pressed color on more button to match app's existing UI.
Also fixed an intrinsic size issue when using UIHostingController in UIKit.
Added second fix to use opacity modifier to show/hide more button. The previous branch logic isn't "SwiftUI-y" and has an "undesirable" animation side effect.